Refactor: block validation #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
approved these changes
Nov 21, 2023
igor-egorov
approved these changes
Nov 21, 2023
| return consensus; | ||
| } | ||
| } | ||
| BOOST_UNREACHABLE_RETURN({}); |
There was a problem hiding this comment.
Do we want to put some SL_CRITICAL message before the macro?
// In order to ease possible debugging after the later changes
There was a problem hiding this comment.
It really unreachable. At least one (last) consensus will be returned as fallback. Empty list throws exception (assert) in ctor
|
|
||
| // TODO: Code for trying to select another consensus | ||
| } | ||
| BOOST_UNREACHABLE_RETURN({}); |
There was a problem hiding this comment.
I suggest covering such cases with log messages, since the code may change and the line might got reached.
There was a problem hiding this comment.
Likely I'll remove selector for finality consensus.
| using testing::Mock; | ||
| using testing::Return; | ||
|
|
||
| class BabeBlockValidatorTest : public testing::Test { |
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Needed for #1591 (as part of preparation for sassafras block validation develop)
Description of the Change
Makes block validation consensus agnostic as more as possible: bock validation will be called from consensus.
This is needed to make validation block internally particular consensus